Repository navigation
refactor: consolidate oversampled-PSF convolution helpers - #361
Merged
Merged
Conversation
Behaviour-preserving (suites 863/946/336 unchanged; ground-truth pins and
np/jax parity verified to machine precision):
- The four _convolved_{image,mapping_matrix}_over_sampled_{np,jax}_from
bodies collapse into two shared engines parameterized by trailing dims
(image = 1D, mapping matrix = 2D) and, for jax, the caller's fft kernel +
dtype (preserving the image/mapping mixed-precision asymmetry documented
in convolved_mapping_matrix_from). The four originals become thin
wrappers keeping their names, signatures and warning semantics.
- .gitignore: test_autoarray/output/ (test-run artifacts leaked into a
commit once on 2026-07-08).
Deferred per the Refactor Agent's too-large verdict, recorded on #360: the
convolver/ package split and the pre-series np/jax/FFT method-variant
duplication.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour-preserving refactor (#360, Refactor Agent conservative cut): the four
_convolved_*_over_sampled_{np,jax}_frombodies collapse into two shared engines parameterized by trailing dims and (for JAX) the caller's FFT kernel + dtype, preserving the documented image/mapping mixed-precision asymmetry; the four originals stay as thin wrappers with unchanged names, signatures and warning semantics. Also gitignorestest_autoarray/output/.Invariant: suites unchanged (PyAutoArray 863, downstream PyAutoGalaxy 946 + PyAutoLens 336 against the branch); ground-truth pins reproduced; np/JAX parity ≤2.2e-16. Net −31 lines. The
convolver/package split is recorded as deferred on #360.🤖 Generated with Claude Code